Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CSP v5 deprecated task for ZKEVM. #101

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Nov 28, 2023

Deployment (restore deprecated task): ComposableStablePool V5 for ZKEVM

We redeployed the exact same build info to zkevm in #98 after the hard fork, but the action IDs for the old pools might still be needed. Therefore they should be recorded somewhere.

By adding this deprecated task just for zkevm we can get the old action IDs verified by CI without changing our current systems.

Just to be super clear: this is not a new deployment, it's just a backup for the data that was erased in #98. All the files in the added task (scripts, artifact, build info) are the exact same as in the active task.

Deployment tasks checklist:

  • Contract(s) deployed to all target networks / testnets
  • TX IDs are properly generated
  • Action IDs are generated after deployment (if applicable)
  • Outputs for all target networks are generated, and linked in the task readme
  • Addresses files are up to date with the new deployment
  • Contracts are verified in every network
  • Deployments CHANGELOG is updated
  • There are no code changes of any kind

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb November 28, 2023 16:47
@jubeira
Copy link
Contributor Author

jubeira commented Nov 28, 2023

@EndymionJkb hide whitespace to review readme :)

Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; cleaner than having to refer to #98

@jubeira jubeira merged commit 42a7877 into master Nov 28, 2023
41 of 42 checks passed
@jubeira jubeira deleted the restore-deprecated-cspv5-zkevm branch November 28, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants