Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: EndymionJkb <[email protected]>
  • Loading branch information
jubeira and EndymionJkb authored Feb 26, 2024
1 parent 18c1198 commit e70c55e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tasks/20240223-composable-stable-pool-v6/readme.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# 2024-02-23 - Composable Stable Pool V6

Deployment of `ComposableStablePoolFactory`, which supersedes `20230711-composable-stable-pool-v5`.
Deployment of `ComposableStablePoolFactory` V6, which supersedes `20230711-composable-stable-pool-v5`.
This version is the same in terms of functionality, but has a longer pause window (4 years) and buffer period (6 months).

## Useful Files
Expand Down
4 changes: 2 additions & 2 deletions tasks/20240223-composable-stable-pool-v6/test/test.fork.ts
Original file line number Diff line number Diff line change
Expand Up @@ -475,15 +475,15 @@ describeForkTest('ComposableStablePool V6', 'mainnet', 19292000, function () {
expect(await currentTimestamp()).to.be.lt(factoryDeploymentTimestamp.add(MINUTE));
});

it('can be paused 4 years after factory deployment', async () => {
it('can be paused until 4 years after factory deployment', async () => {
const pool = await createPool(tokens, ZERO_ADDRESS, false, ZERO_BYTES32);
await authorizer.connect(govMultisig).grantRole(await actionId(pool, 'pause'), govMultisig.address);
await advanceTime(EXPECTED_PAUSE_WINDOW - MINUTE);
const tx = await pool.connect(govMultisig).pause();
expectEvent.inReceipt(await tx.wait(), 'PausedStateChanged', { paused: true });
});

it('cannot be paused 4 years after factory deployment', async () => {
it('cannot be paused more than 4 years after factory deployment', async () => {
const pool = await createPool(tokens, ZERO_ADDRESS, false, ZERO_BYTES32);
await authorizer.connect(govMultisig).grantRole(await actionId(pool, 'pause'), govMultisig.address);
await advanceTime(EXPECTED_PAUSE_WINDOW + MINUTE);
Expand Down

0 comments on commit e70c55e

Please sign in to comment.