Feat/sor update #190
Merged
Feat/sor update #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
franzns
commented
Mar 5, 2024
•
franzns
commented
- Updating to the newest b-sdk version
- Refactoring SOR service to use new models
- Remove unused code
|
doublecheck if type change on route hop breaks v2 beets UI |
|
I just smoke tested few swaps and works fine. Although not sure about the returned paths, because they seem to be gas intensive, for example: USDC > DAI returns a path with 8 swaps. That's a side note, more related to the sor logic than this PR itself. |
gmbronco
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.