-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a Balancer API provider to fetch pool state for join txs; #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngrantuk
reviewed
Sep 22, 2023
Would be nice to add examples showing how this can be used, could add one for join and one for exit. |
johngrantuk
reviewed
Sep 22, 2023
Changing variable names; Changing class names;
Changing function name;
Creating example for Join Weighted Pool;
…e-api # Conflicts: # src/entities/exit/parser.ts # src/entities/join/parser.ts # test/weightedExit.integration.test.ts
brunoguerios
previously requested changes
Sep 27, 2023
Replacing Type PoolState for PoolStateInput; Updating README.md examples section;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about why lint and test checks are failing, but otherwise LGTM 👍
johngrantuk
reviewed
Oct 16, 2023
johngrantuk
reviewed
Oct 16, 2023
@lgahdl once the latest updates are pushed can you generate a changelog for the PR please. |
clarifying query and variables parameters type on fetch function;
…e-api # Conflicts: # .gitignore # README.md # package.json
johngrantuk
reviewed
Oct 23, 2023
johngrantuk
reviewed
Oct 23, 2023
johngrantuk
reviewed
Oct 23, 2023
johngrantuk
reviewed
Oct 23, 2023
Changing chainId types to ChainId instead of number; Adding a resolution to install get-port in the version 5.1.2, to accept non ESM imports, since @viem/anvil import this package using require;
johngrantuk
reviewed
Oct 24, 2023
johngrantuk
reviewed
Oct 24, 2023
johngrantuk
reviewed
Oct 24, 2023
replacing ts-node by tsx; removing tsconfig-paths; removing resolutions; updating pnpm-lock.yaml;
johngrantuk
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Balancer API Provider is a utility module designed to provide data for b-sdk functions, initially it will provide pool state input for both join's and exit's, it's divided in "client" and the "modules",
Balancer API Client:
A Http Client that fetches the data from a specified url using a GraphQL query, the url is expected to be from a Beethoven X API or Balancer API, in this link there are some valid urls.
Balancer API Modules:
As a first use case, the module "pool-state" was implemented to provide data for exit's and join's functions of the b-sdk, other modules will implement different data fetchings with different data structures that will be important for other b-sdk functionalities.