Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate queryRemoveLiquidityRecovery #533

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Remove duplicate queryRemoveLiquidityRecovery #533

merged 3 commits into from
Dec 16, 2024

Conversation

brunoguerios
Copy link
Member

@brunoguerios brunoguerios commented Dec 11, 2024 •
edited
Loading

Closes #531

-- IMPORTANT --
Please note that this bumps a major version as it's a breaking change to the external interface.
I think that should be ok as we're preparing to release v1.0

@brunoguerios brunoguerios self-assigned this Dec 11, 2024
MattPereira
MattPereira approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea and squeaky clean! 🧼

johngrantuk
johngrantuk approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to tidy.
I think it might be helpful to extend the changset a bit to explain whats changed and how a user can update on their side.

@brunoguerios
Copy link
Member Author

@johngrantuk - let me know what you think about the new changeset message:

Remove queryRemoveLiquidityRecovery from RemoveLiquidity. Please use query with RemoveLiquidityRecoveryInput instead.

@johngrantuk
Copy link
Member

@johngrantuk - let me know what you think about the new changeset message:

Remove queryRemoveLiquidityRecovery from RemoveLiquidity. Please use query with RemoveLiquidityRecoveryInput instead.

Looks good, thanks.

@brunoguerios brunoguerios merged commit 3201a1e into main Dec 16, 2024
4 checks passed
@brunoguerios brunoguerios deleted the refactor-query-remove-recovery branch December 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattPereira MattPereira MattPereira approved these changes

@mkflow27 mkflow27 Awaiting requested review from mkflow27

@johngrantuk johngrantuk Awaiting requested review from johngrantuk

Assignees

@brunoguerios brunoguerios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate queryRemoveLiquidityRecovery for v3
3 participants
@brunoguerios @johngrantuk @MattPereira