-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Permit and Permit2 signature docs #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempt to run this script seems to result in the following error:
[ b-sdk ] $ pnpm example ./examples/addLiquidity/addLiquidityUnbalanced.ts
> @balancer/sdk@0.32.2 example /home/matthu/Desktop/Balancer/b-sdk
> npx tsx ./examples/lib/executeExample.ts "./examples/addLiquidity/addLiquidityUnbalanced.ts"
checking rpcUrl 8945 {}
🛠️ Starting anvil { port: 8945, forkBlockNumber: 7010800n }
/home/matthu/Desktop/Balancer/b-sdk/src/data/providers/balancer-api/modules/pool-state/index.ts:54
...data.poolGetPool,
^
TypeError: Cannot read properties of null (reading 'poolGetPool')
at Pools.fetchPoolState (/home/matthu/Desktop/Balancer/b-sdk/src/data/providers/balancer-api/modules/pool-state/index.ts:54:21)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async addLiquidityExample (/home/matthu/Desktop/Balancer/b-sdk/examples/addLiquidity/addLiquidityUnbalanced.ts:82:23)
at async runAgainstFork (/home/matthu/Desktop/Balancer/b-sdk/examples/addLiquidity/addLiquidityUnbalanced.ts:47:18)
at async executeExample (/home/matthu/Desktop/Balancer/b-sdk/examples/lib/executeExample.ts:6:5)
Node.js v20.17.0
ELIFECYCLE Command failed with exit code 1
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried moving the forkBlockNumber
but still fails with same poolGetPool
error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the API is on deploy11 but the pool is from deploy10?
Heres a tenderly simulation at deploy11 vault explorer that shows pool is not registered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR is on deploy 10 and API is on deploy 11
Examples run fine after merging main into this PR and updating with a deploy 11 pool address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking that!
You're right - sorry - I had this open before updating to deploy11.
I'll update the PR over here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done ✅
Closes #369