Refactor nestedPoolState logic to fetch mainTokens from api #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoguerios
requested review from
johngrantuk,
mkflow27,
MattPereira and
franzns
franzns
reviewed
Nov 12, 2024
| }); | ||
| // mainTokens are pool tokens filtering out nested pools and phantomBPTs | ||
| const mainTokens = pool.poolTokens.flatMap((t) => { | ||
| if (t.nestedPool) { |
There was a problem hiding this comment.
Think you need to filter the phantomBPT first, otherwise you get the mainTokens of the parent pool twice.
Also think about duplicated tokens. A usdc/bb-a-usd pool would have 2x usdc, do you need it twice or just once?
There was a problem hiding this comment.
You're right about filtering out phantomBPT from the parent pool - I'll fix that.
But we don't have to worry about duplicate tokens as that's not supported by the SDK - it will fail in the validator. There shouldn't exist such a pool composition.
There was a problem hiding this comment.
I changed the logic a bit to make it simpler and easier to read/understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #488