Manually add BPT in CS API Provider #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken list (as current SG does) It does not currently do this so we have to add it manually
brunoguerios
reviewed
Nov 9, 2023
| * It does not currently do this so we have to add it manually | ||
| */ | ||
| if (poolGetPool.type === 'PHANTOM_STABLE') { | ||
| let missingBPTIndex = 0; |
There was a problem hiding this comment.
Since they are still experimenting with adding/removing the BPT on v3-canary branch, we could make this code resilient by simply checking if pool tokens contains the pool address. If yes, then BPT is present and we don't need to add it.
There was a problem hiding this comment.
Good suggestion! Added that check now.
brunoguerios
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on assumption that API will return BPT token in token list (as current SG does) It does not currently do this so we have to add it manually.