Changing Hardhat client to anvil on join and exit tests; #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 21, 2023 19:26
Changing variable names; Changing class names;
Changing function name;
Creating example for Join Weighted Pool;
…e-api # Conflicts: # src/entities/exit/parser.ts # src/entities/join/parser.ts # test/weightedExit.integration.test.ts
Replacing Type PoolState for PoolStateInput; Updating README.md examples section;
Obs.: Still working with hardhat;
|
Can you please separate changes from API branch and this PR? It's hard to review with changes mixed like this. |
Yeah, of course, I'll separe the changes and do change the api examples to anvil client in the api branch, thanks for the tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The Balancer API branch is merged on this one