forked from javascript-tutorial/az.javascript.info
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from javascript-tutorial/az.javascript.info repository #1
Open
orkhan-huseyn
wants to merge
761
commits into
bakujsdevs:master
Choose a base branch
from
javascript-tutorial:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicated `also`.
Fix: typos in <5-network/02-formdata/article.md>
Fix err in syntax
Update article.md
fixed a word 'operational' to be 'operating'
typo
Update article.md
replace russian-english comment with english
modified a sentence
'and want' to implement...
'that allow to' -> 'that allow us to'
'allows to' -> 'allows us to'
'use the event delegation' -> 'use event delegation'
'awaits till `onclick`' -> "waits until the `onclick`". "awaits" doesn't usually go with "until" (or "till" or "'til"). I can await someone's arrival, or I can wait until they arrive. An alternate phrasing using "await" could be "it awaits the completion of the `onclick` processing".
Update article.md
Rephrasing about 1 second delay / horizontal ruler.
Update article.md
Fixing urls to start with 'https'
"returns the result outside" -> "returns the result to the outside"
Several punctuation changes, yielding: "1. We use the browser [fetch](info:fetch) method to download from a remote URL. It allows us to supply authorization and other headers if needed -- here GitHub requires `User-Agent`. 2. The fetch result is parsed as JSON. That's again a `fetch`-specific method. 3. We should get the next page URL from the `Link` header of the response. It has a special format, so we use a regexp for that. The next page URL may look like `https://api.github.com/repositories/93253246/commits?page=2`. It's generated by GitHub itself. 4. Then we yield all commits received, and when they finish, the next `while(url)` iteration will trigger, making one more request."
"such as browsers" -> "like in browsers"
"`import` allows to import functionality.." -> "`import` allows the import of functionality..." "relative the current file" -> "relative to the current file,"
"That's the correct variant:" -> "This is the correct variant:"
"Let's see that on examples." -> "Let's look at them using examples:"
"allows to configure" -> "allows us to configure"
"be aware that HTML-page" -> "be aware that the HTML page"
"`async` attribute" -> "the `async` attribute"
This reverts commit e4fb777.
This reverts commit d6035ee.
"better convenience" -> "more convenience"
"That's not a function" -> "It's not a function"
"chapter" -> "article" (6 times or so) I believe that is consistent with the agreed-upon terminology.
"as `Proxy` trap" -> "as the `Proxy` trap"
….info into sync-10c7807f
Translate Hello World page
browser first article translated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.