-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add range to topic directive with range data fetcher #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to also have some basic validation rules for the range arguments, e.g. only possible with list return type, key field must be set etc.
@torbsto isn't that what you mean: Lines 72 to 80 in 6d4e23e
|
No, this checks if the DataFetcher can be applied to the given field. I'm talking about validation rules, that detect incorrect usages of the topic directive as implemented in https://github.com/bakdata/quick/tree/master/gateway/src/main/java/com/bakdata/quick/gateway/directives/topic/rule/validation |
common/src/main/java/com/bakdata/quick/common/api/client/MirrorClient.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/bakdata/quick/common/api/client/PartitionedMirrorClient.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/bakdata/quick/gateway/directives/topic/rule/fetcher/RangeFetcherRule.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/bakdata/quick/gateway/directives/topic/rule/validation/RangeArguments.java
Outdated
Show resolved
Hide resolved
.../main/java/com/bakdata/quick/gateway/directives/topic/rule/validation/ValidationUtility.java
Outdated
Show resolved
Hide resolved
...ources/schema/conversion/shouldNotConvertIfKeyArgAndInputNameDifferentInNonQueryType.graphql
Show resolved
Hide resolved
…y/add-range-data-fetcher � Conflicts: � common/src/main/java/com/bakdata/quick/common/api/client/PartitionedMirrorClient.java � common/src/main/java/com/bakdata/quick/common/api/model/mirror/MirrorHost.java � gateway/src/main/java/com/bakdata/quick/gateway/fetcher/MirrorDataFetcherClient.java
...src/main/java/com/bakdata/quick/gateway/directives/topic/rule/validation/RangeArguments.java
Outdated
Show resolved
Hide resolved
.../main/java/com/bakdata/quick/gateway/directives/topic/rule/validation/ValidationUtility.java
Show resolved
Hide resolved
…akdata/quick into feature/gateway/add-range-data-fetcher
Closes #57 and #59