Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide operation_mode from KPOps config #571

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

raminqaf
Copy link
Contributor

No description provided.

@raminqaf raminqaf added type/bug component/config Related to pipeline config labels Dec 19, 2024
@raminqaf raminqaf requested a review from disrupted as a code owner December 19, 2024 12:21
@raminqaf raminqaf self-assigned this Dec 19, 2024
@@ -1,3 +1,5 @@
# type: ignore[reportGeneralTypeIssues]
Copy link
Contributor Author

@raminqaf raminqaf Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that after you reverted poetry.lock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why? you didn't make any changes to this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue why. I couldn't find a good answer. The errors are also very generic, and I don't really understand why they are being triggered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to revert poetry.lock to main and run poetry lock --no-update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still breaks... I have no clue...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file keeps being overriten. Even if I delete the .venv folder and revert the poetry.lock file and run poetry lock --no-update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes to poetry.lock are to be expected from the update to Python 3.11, but none should be regarding Pyright or Pydantic
do you see the same errors when you run pyright kpops/utils/gen_schema.py? because I don't. Only with pre-commit run pyright -a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I run the command pre-commit run --all-files I get the errors

poetry.lock Outdated Show resolved Hide resolved
@raminqaf raminqaf merged commit ecc8f62 into v9 Dec 20, 2024
7 checks passed
@raminqaf raminqaf deleted the fix/remove-operation-mode-from-config branch December 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config Related to pipeline config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants