Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call destroy from inside of reset or clean #501

Merged
merged 16 commits into from
Jul 15, 2024
Merged

Call destroy from inside of reset or clean #501

merged 16 commits into from
Jul 15, 2024

Conversation

raminqaf
Copy link
Contributor

No description provided.

@raminqaf raminqaf added the type/refactor Refactoring of existing functionality label Jun 27, 2024
@raminqaf raminqaf self-assigned this Jun 27, 2024
disrupted
disrupted reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a look if you can make the other descriptions also a little more concise

kpops/components/streams_bootstrap/producer/producer_app.py Outdated Show resolved Hide resolved
@raminqaf raminqaf added the breaking-change Indicates that this PR introduces a breaking change label Jul 11, 2024
raminqaf added 2 commits July 11, 2024 13:17
@raminqaf
Merge branch 'main' of github.com:bakdata/kpops into refactor/move-de…
aa0ce48 
…stroy-in-clean

# Conflicts:
#	kpops/components/streams_bootstrap/__init__.py
#	tests/components/test_streams_bootstrap.py
@raminqaf
Update files
2153320
@raminqaf raminqaf changed the base branch from main to v7 July 11, 2024 12:37
disrupted
disrupted reviewed Jul 11, 2024
View reviewed changes
docs/docs/user/migration-guide/v6-v7.md Outdated Show resolved Hide resolved
docs/docs/user/migration-guide/v6-v7.md Outdated Show resolved Hide resolved
docs/docs/user/migration-guide/v6-v7.md Outdated Show resolved Hide resolved
kpops/components/base_components/kafka_connector.py Outdated Show resolved Hide resolved
kpops/components/common/streams_bootstrap.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted July 12, 2024 08:36
@raminqaf raminqaf requested a review from disrupted July 15, 2024 08:23
disrupted
disrupted requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

docs/docs/user/migration-guide/v6-v7.md Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted July 15, 2024 09:50
@raminqaf raminqaf merged commit bcef0e5 into v7 Jul 15, 2024
6 checks passed
@raminqaf raminqaf deleted the refactor/move-destroy-in-clean branch July 15, 2024 09:52
@raminqaf raminqaf mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@sujuka99 sujuka99 Awaiting requested review from sujuka99

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raminqaf @disrupted