Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cleaning StatefulSets with PVCs #482

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Add support for cleaning StatefulSets with PVCs #482

merged 10 commits into from
Apr 25, 2024

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Apr 9, 2024

No description provided.

philipp94831
philipp94831 previously requested changes Apr 9, 2024
View reviewed changes
kpops/components/streams_bootstrap/streams/model.py Outdated Show resolved Hide resolved
@raminqaf raminqaf changed the title Add Stateful Stream Apps component Add support for cleaning StatefulSets with PVCs Apr 25, 2024
@raminqaf raminqaf requested a review from philipp94831 April 25, 2024 08:12
@raminqaf raminqaf self-assigned this Apr 25, 2024
@raminqaf raminqaf added type/enhancement New feature or request component/handlers Related to component handlers component/pipeline-components Related to pipeline components labels Apr 25, 2024
@raminqaf raminqaf marked this pull request as ready for review April 25, 2024 08:13
@raminqaf raminqaf requested a review from disrupted April 25, 2024 08:58
disrupted
disrupted reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, otherwise LGTM

kpops/component_handlers/kubernetes/pvc_handler.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted April 25, 2024 11:37
@raminqaf raminqaf enabled auto-merge (squash) April 25, 2024 12:02
@raminqaf raminqaf disabled auto-merge April 25, 2024 14:50
@raminqaf raminqaf enabled auto-merge (squash) April 25, 2024 14:51
@raminqaf raminqaf merged commit f9763d5 into main Apr 25, 2024
8 of 9 checks passed
@raminqaf raminqaf deleted the feature/add-stateful-stream-app branch April 25, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@philipp94831 philipp94831 Awaiting requested review from philipp94831

@sujuka99 sujuka99 Awaiting requested review from sujuka99

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
component/handlers Related to component handlers component/pipeline-components Related to pipeline components type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raminqaf @philipp94831 @disrupted