Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ruff #363

Merged
merged 77 commits into from
Oct 9, 2023
Merged

Introduce ruff #363

merged 77 commits into from
Oct 9, 2023

Conversation

sujuka99
Copy link
Contributor

Replaces isort, pyupgrade, flake8 with ruff

@sujuka99 sujuka99 added the area/CI Relates to GitHub actions label Sep 26, 2023
@sujuka99 sujuka99 added this to the Hardening KPOps milestone Sep 26, 2023
@sujuka99 sujuka99 self-assigned this Sep 26, 2023
@sujuka99
Copy link
Contributor Author

The problem matcher seems to work now

@sujuka99 sujuka99 marked this pull request as ready for review September 27, 2023 14:50
@disrupted
Copy link
Member

The problem matcher seems to work now

is it possible to change the displayed name from Test to Ruff?

disrupted
disrupted reviewed Sep 27, 2023
View reviewed changes
README.md Show resolved Hide resolved
@sujuka99
Copy link
Contributor Author

The problem matcher seems to work now

is it possible to change the displayed name from Test to Ruff?

The only way I can see is to put Ruff into a separate job

@raminqaf
Copy link
Contributor

I agree with @disrupted that we should gradually introduce the changes (fixes) made by Ruff. Maybe it would be good to ignore most of the (critical) rules at first and do them step by step in follow-up PRs to avoid breaking the code.

@disrupted
Copy link
Member

I agree with @disrupted that we should gradually introduce the changes (fixes) made by Ruff. Maybe it would be good to ignore most of the (critical) rules at first and do them step by step in follow-up PRs to avoid breaking the code.

I will look through all of the changes today and add comments if I run into particularly big changes. otherwise, of course it's best practice to bundle formatting changes in one big commit since it's easier to exclude from git blame.

@disrupted
Copy link
Member

is it possible to change the displayed name from Test to Ruff?

The only way I can see is to put Ruff into a separate job

ok, then it's fine

disrupted
disrupted previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🤩
(almost) no complaints :)

.github/ruff-matcher.json Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
kpops/component_handlers/__init__.py Show resolved Hide resolved
kpops/component_handlers/helm_wrapper/helm.py Show resolved Hide resolved
tests/cli/test_schema_generation.py Show resolved Hide resolved
tests/compiler/test_pipeline_name.py Show resolved Hide resolved
tests/component_handlers/schema_handler/test_schema_handler.py Outdated Show resolved Hide resolved
tests/pipeline/snapshots/snap_test_example.py Outdated Show resolved Hide resolved
tests/pipeline/snapshots/snap_test_pipeline.py Outdated Show resolved Hide resolved
@sujuka99 sujuka99 dismissed disrupted’s stale review October 2, 2023 18:27

adressed points

disrupted
disrupted previously approved these changes Oct 5, 2023
View reviewed changes
@sujuka99 sujuka99 merged commit 74dd373 into main Oct 9, 2023
8 checks passed
@sujuka99 sujuka99 deleted the ci/introduce-ruff branch October 9, 2023 07:58
@irux irux mentioned this pull request Oct 18, 2023
Closed
irux pushed a commit that referenced this pull request Oct 30, 2023
@sujuka99 @irux
Revert "Introduce ruff (#363)"
ac9a01c 
This reverts commit 74dd373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@raminqaf raminqaf Awaiting requested review from raminqaf

@irux irux Awaiting requested review from irux

Assignees

@sujuka99 sujuka99

Labels
area/CI Relates to GitHub actions
Projects
None yet
Milestone
Hardening KPOps
Development

Successfully merging this pull request may close these issues.
3 participants
@sujuka99 @disrupted @raminqaf