Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variables documentation generation #362

Merged
merged 21 commits into from
Sep 26, 2023
Merged

Fix environment variables documentation generation #362

merged 21 commits into from
Sep 26, 2023

Conversation

sujuka99
Copy link
Contributor

closes #359

@sujuka99 sujuka99 self-assigned this Sep 22, 2023
disrupted
disrupted requested changes Sep 25, 2023
View reviewed changes
hooks/gen_docs/__init__.py Outdated Show resolved Hide resolved
hooks/gen_docs/__init__.py Outdated Show resolved Hide resolved
disrupted
disrupted requested changes Sep 26, 2023
View reviewed changes
hooks/gen_docs/__init__.py Outdated Show resolved Hide resolved
hooks/gen_docs/gen_docs_env_vars.py Outdated Show resolved Hide resolved
disrupted
disrupted previously requested changes Sep 26, 2023
View reviewed changes
tests/utils/test_doc_gen.py Outdated Show resolved Hide resolved
hooks/gen_docs/gen_docs_env_vars.py Show resolved Hide resolved
@sujuka99 sujuka99 requested a review from disrupted September 26, 2023 11:50
@sujuka99 sujuka99 requested a review from raminqaf September 26, 2023 11:51
disrupted
disrupted reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a nitpick

hooks/gen_docs/__init__.py Outdated Show resolved Hide resolved
tests/utils/test_doc_gen.py Outdated Show resolved Hide resolved
@sujuka99 sujuka99 requested a review from disrupted September 26, 2023 12:29
@sujuka99 sujuka99 merged commit a61c4e4 into main Sep 26, 2023
7 checks passed
@sujuka99 sujuka99 deleted the fix/docs-env-gen branch September 26, 2023 13:19
irux added a commit that referenced this pull request Oct 30, 2023
@irux
Revert "Fix environment variables documentation generation (#362)"
7fa4683 
This reverts commit a61c4e4.
irux added a commit that referenced this pull request Oct 30, 2023
@irux
Revert "Revert "Fix environment variables documentation generation (#362
7d12c30 
)""

This reverts commit 7fa4683.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@irux irux Awaiting requested review from irux

@raminqaf raminqaf Awaiting requested review from raminqaf

Assignees

@sujuka99 sujuka99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc generation script for environment variables should visit nested fields
3 participants
@sujuka99 @disrupted @raminqaf