Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Kafka REST Proxy & Kafka Connect hosts default and improve Schema Registry config #354

Merged
merged 26 commits into from
Oct 5, 2023
Merged

Make Kafka REST Proxy & Kafka Connect hosts default and improve Schema Registry config #354

merged 26 commits into from
Oct 5, 2023

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Sep 6, 2023 •
edited
Loading

Fixes #17

@raminqaf raminqaf self-assigned this Sep 6, 2023
@raminqaf raminqaf added type/refactor Refactoring of existing functionality component/config Related to pipeline config breaking-change Indicates that this PR introduces a breaking change labels Sep 6, 2023
@raminqaf raminqaf marked this pull request as ready for review September 6, 2023 12:53
@disrupted disrupted changed the title Make Kafka rest proxy & connect hosts default and improve schema registry config Make Kafka REST Proxy & Kafka Connect hosts default and improve Schema Registry config Sep 6, 2023
disrupted
disrupted requested changes Sep 6, 2023
View reviewed changes
docs/docs/schema/config.json Outdated Show resolved Hide resolved
docs/docs/schema/config.json Show resolved Hide resolved
kpops/cli/pipeline_config.py Show resolved Hide resolved
kpops/component_handlers/kafka_connect/connect_wrapper.py Outdated Show resolved Hide resolved
kpops/component_handlers/schema_handler/schema_handler.py Outdated Show resolved Hide resolved
disrupted
disrupted requested changes Sep 6, 2023
View reviewed changes
kpops/component_handlers/schema_handler/schema_handler.py Outdated Show resolved Hide resolved
kpops/cli/pipeline_config.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted September 8, 2023 07:33
@raminqaf raminqaf requested a review from disrupted September 11, 2023 08:33
disrupted
disrupted requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set base branch to v3

kpops/component_handlers/topic/proxy_wrapper.py Outdated Show resolved Hide resolved
docs/docs/resources/examples/defaults.md Outdated Show resolved Hide resolved
docs/docs/resources/variables/config_env_vars.md Outdated Show resolved Hide resolved
kpops/cli/main.py Outdated Show resolved Hide resolved
kpops/component_handlers/kafka_connect/kafka_connect_handler.py Outdated Show resolved Hide resolved
kpops/component_handlers/schema_handler/schema_handler.py Outdated Show resolved Hide resolved
tests/cli/test_handlers.py Outdated Show resolved Hide resolved
@raminqaf raminqaf changed the base branch from main to v3 September 11, 2023 10:01
disrupted
disrupted reviewed Sep 11, 2023
View reviewed changes
kpops/cli/config.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed Sep 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted September 27, 2023 14:33
disrupted
disrupted requested changes Sep 27, 2023
View reviewed changes
docs/docs/resources/variables/config_env_vars.md Show resolved Hide resolved
docs/docs/user/migration-guide/v2-v3.md Outdated Show resolved Hide resolved
docs/docs/user/migration-guide/v2-v3.md Outdated Show resolved Hide resolved
docs/docs/user/migration-guide/v2-v3.md Outdated Show resolved Hide resolved
hooks/gen_docs/gen_docs_env_vars.py Outdated Show resolved Hide resolved
kpops/cli/config.py Outdated Show resolved Hide resolved
kpops/cli/config.py Outdated Show resolved Hide resolved
tests/cli/test_handlers.py Outdated Show resolved Hide resolved
tests/cli/test_kpops_config.py Outdated Show resolved Hide resolved
docs/docs/resources/variables/config_env_vars.env Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted September 29, 2023 09:15
@raminqaf raminqaf mentioned this pull request Oct 5, 2023
Closed
@raminqaf raminqaf added this to the v3.0 milestone Oct 5, 2023
@raminqaf raminqaf merged commit b800dcc into v3 Oct 5, 2023
@raminqaf raminqaf deleted the feature/make-host-default branch October 5, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujuka99 sujuka99 sujuka99 approved these changes

@disrupted disrupted disrupted approved these changes

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
breaking-change Indicates that this PR introduces a breaking change component/config Related to pipeline config type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raminqaf @disrupted @sujuka99