Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support networkx to represent components as a graph #331

Merged
merged 41 commits into from
Sep 18, 2023
Merged

Support networkx to represent components as a graph #331

merged 41 commits into from
Sep 18, 2023

Conversation

irux
Copy link
Contributor

@irux irux commented Aug 22, 2023

closes #284

@irux irux marked this pull request as ready for review August 29, 2023 09:58
disrupted
disrupted requested changes Aug 30, 2023
View reviewed changes
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
tests/components/test_streams_app.py Outdated Show resolved Hide resolved
disrupted
disrupted requested changes Sep 5, 2023
View reviewed changes
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
disrupted
disrupted requested changes Sep 12, 2023
View reviewed changes
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
tests/pipeline/resources/pipelines-with-graphs/simple-pipeline/defaults.yaml Outdated Show resolved Hide resolved
tests/pipeline/resources/pipelines-with-graphs/same-topic-and-component-name/defaults.yaml Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
disrupted
disrupted requested changes Sep 12, 2023
View reviewed changes
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
kpops/components/base_components/pipeline_component.py Outdated Show resolved Hide resolved
@irux irux requested a review from disrupted September 12, 2023 11:54
disrupted
disrupted requested changes Sep 12, 2023
View reviewed changes
kpops/components/base_components/pipeline_component.py Outdated Show resolved Hide resolved
kpops/components/base_components/pipeline_component.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
@disrupted disrupted added type/enhancement New feature or request component/generator Related to the generation of pipeline.yaml component/pipeline-components Related to pipeline components labels Sep 12, 2023
disrupted
disrupted reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits, looks good otherwise :)

kpops/components/streams_bootstrap/streams/streams_app.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline_generator/pipeline.py Outdated Show resolved Hide resolved
disrupted
disrupted approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irux irux merged commit 691fe62 into feature/parallelization Sep 18, 2023
7 checks passed
@irux irux deleted the feature/networkx branch September 18, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@raminqaf raminqaf Awaiting requested review from raminqaf

@sujuka99 sujuka99 Awaiting requested review from sujuka99

Assignees

@irux irux

Labels
component/generator Related to the generation of pipeline.yaml component/pipeline-components Related to pipeline components type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irux @disrupted @sujuka99