Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clean-deploy and reset-deploy commands #304

Closed
wants to merge 6 commits into from
Closed

Add clean-deploy and reset-deploy commands #304

wants to merge 6 commits into from

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Jul 27, 2023 •
edited
Loading

Fixes #303

@raminqaf raminqaf changed the title Add command Add reprocess command Jul 27, 2023
@raminqaf raminqaf self-assigned this Jul 27, 2023
@raminqaf raminqaf added type/enhancement New feature or request component/cli Related to the CLI commands labels Jul 27, 2023
@raminqaf raminqaf marked this pull request as ready for review July 27, 2023 13:25
philipp94831
philipp94831 reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@philipp94831 philipp94831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a test?

@raminqaf
Copy link
Contributor Author

What about a test?

We don't have tests for the deploy, destroy, reset, and clean commands. There is an issue open for it: #16

@raminqaf raminqaf changed the title Add reprocess command Add clean-deploy and reset-deploy commands Jul 28, 2023
disrupted
disrupted requested changes Jul 31, 2023
View reviewed changes
kpops/cli/main.py
Comment on lines +394 to +414
clean(
pipeline_base_dir,
pipeline_path,
components_module,
defaults,
config,
steps,
dry_run,
verbose,
)

deploy(
pipeline_base_dir,
pipeline_path,
components_module,
defaults,
config,
steps,
dry_run,
verbose,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equivalent of running kpops clean && kpops deploy?

@raminqaf
Copy link
Contributor Author

raminqaf commented Aug 1, 2023

Closing PR because this can now be achieved through #306 and doesn't need to be natively build in KPOps

@raminqaf raminqaf closed this Aug 1, 2023
@raminqaf raminqaf deleted the feature/add-reprocess branch July 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp94831 philipp94831 philipp94831 left review comments

@disrupted disrupted disrupted requested changes

@sujuka99 sujuka99 Awaiting requested review from sujuka99

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
component/cli Related to the CLI commands type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clean-deploy and reset-deploy commands
3 participants
@raminqaf @philipp94831 @disrupted