Skip to content

Commit

Permalink
style: Update TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
sujuka99 committed Nov 9, 2023
1 parent 0f2ee80 commit d28c136
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions hooks/gen_docs/gen_docs_env_vars.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,6 @@ def fill_csv_pipeline_config(target: Path) -> None:
field_name,
)


# TODO(Ivan Yordanov): Separate complex fields into their "leaves"
def collect_fields(model: type[BaseModel]) -> dict[str, Any]:
"""Collect and return a ``dict`` of all fields in a settings class.
Expand Down
2 changes: 1 addition & 1 deletion kpops/pipeline_generator/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def substitute_in_component(self, component_as_dict: dict) -> dict:
config = self.config
# Leftover variables that were previously introduced in the component by the substitution
# functions, still hardcoded, because of their names.
# TODO: Get rid of them
# TODO(Ivan Yordanov): Get rid of them
substitution_hardcoded = {
"error_topic_name": config.topic_name_config.default_error_topic_name,
"output_topic_name": config.topic_name_config.default_output_topic_name,
Expand Down

0 comments on commit d28c136

Please sign in to comment.