Skip to content

Commit

Permalink
Update files
Browse files Browse the repository at this point in the history
  • Loading branch information
raminqaf committed Jun 26, 2024
1 parent e3ea6af commit 8b5a5a7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
10 changes: 0 additions & 10 deletions kpops/components/base_components/kafka_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,6 @@ def connector_config_should_have_component_name(
app["name"] = component_name
return KafkaConnectorConfig(**app)

# @pydantic.model_validator(mode="after")
# def warning_for_latest_image_tag(self) -> Self:
# resetter_image_tag = self.resetter_values.get("imageTag")
# if not resetter_image_tag or resetter_image_tag == "latest":
# log.warning(
# f"The imageTag for the Kafka Connect resetter in component '{self.name}' is not set and defaults to 'latest'. "
# f"Please, consider providing a stable imageTag."
# )
# return self

@cached_property
def _resetter(self) -> KafkaConnectorResetter:
kwargs: dict[str, Any] = {}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
helm-app:
name: ${component.type}
namespace: example-namespace
app:
imageTag: latest

0 comments on commit 8b5a5a7

Please sign in to comment.