Skip to content

Commit

Permalink
add review
Browse files Browse the repository at this point in the history
  • Loading branch information
raminqaf committed Sep 18, 2023
1 parent fafc12d commit 795c974
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions kpops/components/base_components/kafka_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def _connector_resetter_release_name(self) -> str:

@property
def _resetter_helm_chart(self) -> str:
"""Get reseter Helm chart
"""Get resetter Helm chart
:return: returns the component resetter's helm chart
"""
Expand All @@ -121,11 +121,6 @@ def dry_run_handler(self) -> DryRunHandler:
helm_diff = HelmDiff(self.config.helm_diff_config)
return DryRunHandler(self.helm, helm_diff, self.namespace)

@property
def _kafka_connect_resetter_chart(self) -> str:
"""Resetter chart for this component"""
return f"{self.repo_config.repository_name}/kafka-connect-resetter"

@property
def helm_flags(self) -> HelmFlags:
"""Return shared flags for Helm commands"""
Expand Down Expand Up @@ -232,7 +227,7 @@ def __install_connect_resetter(
return self.helm.upgrade_install(
release_name=self._connector_resetter_release_name,
namespace=self.namespace,
chart=self._kafka_connect_resetter_chart,
chart=self._resetter_helm_chart,
dry_run=dry_run,
flags=HelmUpgradeInstallFlags(
create_namespace=self.config.create_namespace,
Expand Down

0 comments on commit 795c974

Please sign in to comment.