Refactor

bakdata · Oct 11, 2023 · 08885eb · 08885eb
1 parent 05d6f2e
commit 08885eb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/kpops/utils/environment.py b/kpops/utils/environment.py
@@ -28,9 +28,7 @@ def values(self) -> set[str]:
         return set(super().values()).union(os.environ.values())
 
     def items(self) -> dict[str, str]:
-        items = dict(super().items())
-        items.update(**os.environ)
-        return items
+        return {**os.environ, **self.data}
 
 
 ENV = Environment()
diff --git a/tests/utils/test_environment.py b/tests/utils/test_environment.py
@@ -40,7 +40,7 @@ def test_normal_behaviour_update_os_environ(system, fake_environment_linux):
     keys = environment.keys()
     assert "TEST" in keys
     assert "test" in environment.values()
-    items = environment.items()
+    items = dict(environment.items())
     assert items["TEST"] == "test"