Use wall-clock time for dead letter record #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The written dead-letter now has the wall-clock time as its record's timestamp. Because the original timestamp would be lost otherwise, there is a new field in the respective dead-letter models called timestamp. To maintain backwards compatibility, it is nullable, but always set starting from this version.
torbsto
changed the title
error-handling-avro/src/test/java/com/bakdata/kafka/AvroDeadLetterProcessorTest.java
Show resolved
Hide resolved
|
Can you also update https://github.com/bakdata/kafka-dead-letter-analyzer? |
|
Code looks good to me, but maybe we can call the new field more specificly |
To make it consinstent with input_value, input_timestamp makes sense. But I also like just timestamp |
|
I changed it to input_timestamp |
philipp94831
previously approved these changes
Jun 21, 2024
error-handling-core/src/main/java/com/bakdata/kafka/ErrorHeaderProcessor.java
Outdated
Show resolved
Hide resolved
philipp94831
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The written dead-letter now has the wall-clock time as its record's timestamp. Because the original timestamp would be lost otherwise, there is a new field in the respective dead-letter models called timestamp. To maintain backwards compatibility, it is nullable, but always set starting from this version.