fix: insert new changelog action #238
Conversation
| @@ -56,16 +56,15 @@ runs: | |||
| gradle-cache: ${{ inputs.gradle-cache }} | |||
| gradle-cache-read-only: ${{ inputs.gradle-cache-read-only }} | |||
|
|
|||
| - name: Generate changelog | |||
| run: ./gradlew -Pchangelog.githubRepository=${{ github.event.repository.name }} -Pchangelog.futureVersionTag=${{ github.ref_name }} -Pchangelog.sinceTag=${{ github.ref_name }} --stacktrace --info generateChangelog ${{ inputs.gradle-refresh-dependencies == 'true' && '--refresh-dependencies' || '' }} | |||
There was a problem hiding this comment.
No need to run gradle setup anymore. You can remove all inputs as well
There was a problem hiding this comment.
@DerTiedemann gradle-setup is still present in this action
| @@ -169,13 +169,10 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Release on Github | |||
| uses: bakdata/ci-templates/actions/java-gradle-release-github@1.49.0 | |||
| uses: bakdata/ci-templates/actions/java-gradle-release-github@tiedemann/fix-java-changelog | |||
There was a problem hiding this comment.
The changes from this PR to the java-gradle-release workflow still need to be reapplied and retested again now that it is working for the GitHub release
There was a problem hiding this comment.
We should also swap the order of changelog generation and tagging, so that the up-to-date Changelog.md file is generated before the tagging, so that it is part of the tag later
| @@ -63,7 +80,7 @@ runs: | |||
| id: git-cliff | |||
| with: | |||
| config: tmp_cliff.toml | |||
| args: "--tag ${{ inputs.tag }} --verbose" | |||
| args: "--tag ${{ inputs.tag }}" | |||
There was a problem hiding this comment.
Shouldn't this include --unreleased as well, so we can generate the changelog for the version that we are about to release?
No description provided.