Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rotateVectorAroundAxis function to Plane class with tests #117

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Add rotateVectorAroundAxis function to Plane class with tests #117

merged 7 commits into from
Nov 27, 2024

Conversation

Jannetty
Copy link
Member

@Jannetty Jannetty commented Nov 23, 2024 •
edited
Loading

Estimated time to review: medium

Linked issues: resolves #116

Description of changes:

  • Added static function to Plane class that rotates a vector around an axis specified in Direction enum using Rodrigues' rotation formula
  • Added tests testing:
    • rotating 0 degrees returns same vector
    • return vector is always unit
    • rotation around each Direction
  • Changed names of helper functions I used in the implementation of the rotation function to make them not specific to a normal vector

@Jannetty Jannetty marked this pull request as ready for review November 25, 2024 17:45
@Jannetty Jannetty self-assigned this Nov 25, 2024
@Jannetty Jannetty added priority: high Urgent problem that blocks the system until the issue is resolved type: feature Improvement or additions to the code base package: potts Related to the potts implementation category: env Related to the env subpackages labels Nov 25, 2024
@Jannetty Jannetty changed the title added rotateUnitVectorAroundAxis function to Plane class and tests Add rotateUnitVectorAroundAxis function to Plane class with tests Nov 25, 2024
@Jannetty Jannetty changed the title Add rotateUnitVectorAroundAxis function to Plane class with tests Add rotateVectorAroundAxis function to Plane class with tests Nov 25, 2024
jessicasyu
jessicasyu approved these changes Nov 25, 2024
View reviewed changes
test/arcade/potts/env/location/PlaneTest.java Outdated Show resolved Hide resolved
test/arcade/potts/env/location/PlaneTest.java Outdated Show resolved Hide resolved
test/arcade/potts/env/location/PlaneTest.java Outdated Show resolved Hide resolved
test/arcade/potts/env/location/PlaneTest.java Outdated Show resolved Hide resolved
src/arcade/potts/env/location/Plane.java Show resolved Hide resolved
@Jannetty Jannetty requested a review from pohaoc2 November 26, 2024 20:05
cainja
cainja approved these changes Nov 27, 2024
View reviewed changes
src/arcade/potts/env/location/Plane.java Show resolved Hide resolved
src/arcade/potts/env/location/Plane.java Show resolved Hide resolved
src/arcade/potts/env/location/Plane.java Show resolved Hide resolved
@Jannetty Jannetty merged commit 30ff4cb into main Nov 27, 2024
6 checks passed
@Jannetty Jannetty deleted the jannetty/enable-Plane-rotation branch November 27, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicasyu jessicasyu jessicasyu approved these changes

@cainja cainja cainja approved these changes

@jacob-evarts jacob-evarts Awaiting requested review from jacob-evarts

@allison-li-1016 allison-li-1016 Awaiting requested review from allison-li-1016

@pohaoc2 pohaoc2 Awaiting requested review from pohaoc2

Assignees

@Jannetty Jannetty

Labels
category: env Related to the env subpackages package: potts Related to the potts implementation priority: high Urgent problem that blocks the system until the issue is resolved type: feature Improvement or additions to the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality to rotate normal vector of Plane
3 participants
@Jannetty @cainja @jessicasyu