CARCADE Refactor 1: Refactor Classes to Support Addition of New Agent, Module, or Action #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allison-li-1016
requested review from
cainja,
jessicasyu,
jacob-evarts,
Jannetty and
pohaoc2
allison-li-1016
changed the base branch from
allison/carcade-refactor
to
main
allison-li-1016
changed the base branch from
main
to
allison/carcade-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the classes with minimal changes that allow for the addition of new agents/module/classes. The changes are limited to a 1 line code change:
Classes with addition of an if/else case:
src/arcade/patch/agent/process/PatchProcessMetabolism.java
src/arcade/patch/agent/cell/PatchCellContainer.java
src/arcade/patch/sim/PatchSimulationHex.java
src/arcade/patch/sim/PatchSimulationRect.java
Updating new module (inflammation) when splitting cells
src/arcade/patch/agent/module/PatchModuleProliferation.java
Changing confluence limit to account for T cell volume
src/arcade/patch/env/grid/PatchGrid.java