Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Newtonsoft.Json by System.Text.Json #86

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Replace Newtonsoft.Json by System.Text.Json #86

wants to merge 3 commits into from

Conversation

FroggieFrog
Copy link

@FroggieFrog FroggieFrog commented Feb 21, 2024 •
edited
Loading

Update 2023-03-05
At the moment it is not possible to remove Newtonsoft.Json, because upstream packages refeence it:

nuget

This PR replaces Newtonsoft.Json with System.Text.Json.

  • more tests to check for differences between both serializers

@Regenhardt
Copy link

Looks like BaGetter.Tests is the only project that references Newtonsoft.Json, can you remove it from that too?

@Regenhardt
Copy link

Wait how is it used in .Core when Core doesn't even reference the lib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs: Author feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FroggieFrog @Regenhardt