Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Laravel API Resource doesn't handle wrapping model relations in their respective API resources
For example: the application defines
PostResource
&TagResource
. The controller fetches posts with their tags and returnsPostResource
collection. The API resource will convert the model to an array usingModel#toArray()
method which casts all relations in the same way.Although there's
TagResource
, it won't be used.Proposed solution
Add base
JsonResource
class that will pipe all related models throughresource()
factory. This will ensure that each related model will be converted to an array using its API Resource.TODO
JsonRecourse
as a fallback resource in the factory