added a unit test

badoo · Sep 6, 2020 · 306e5a3 · 306e5a3
1 parent 0e108f2
commit 306e5a3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/Server/CBXCUITestServer.m b/Server/CBXCUITestServer.m
@@ -65,6 +65,7 @@ - (instancetype)init_private {
 
         [_server setTXTRecordDictionary:capabilities];
         [self registerRoutes];
+        [self setServerPort];
     }
     return self;
 }
@@ -93,8 +94,6 @@ - (void)start {
     NSError *error;
     BOOL serverStarted = NO;
 
-    [self setServerPort];
-
     DDLogDebug(@"Attempting to start the DeviceAgent server");
     serverStarted = [self attemptToStartWithError:&error];
 

diff --git a/TestApp/DeviceAgentUnitTests/CBXUITestServerTest.m b/TestApp/DeviceAgentUnitTests/CBXUITestServerTest.m
@@ -1,6 +1,8 @@
 
 #import "CBXServerUnitTestUmbrellaHeader.h"
 #import "CBXCUITestServer.h"
+#import "CBXConstants.h"
+#import <OCMock/OCMock.h>
 #import "RoutingHTTPServer.h"
 
 @interface CBXCUITestServer (CBXTEST)
@@ -43,4 +45,15 @@ - (void)testInitPrivateSetsServerAndRegistersRoutes {
     expect(self.testServer.isFinishedTesting).to.equal(NO);
 }
 
+-(void)testInitSetsDefaultPort {
+    expect(self.testServer.server.port).equal(CBX_DEFAULT_SERVER_PORT);
+}
+
+-(void)testPassingPortFromEnvironment {
+    id processInfoMock = OCMClassMock([NSProcessInfo class]);
+    OCMStub([[processInfoMock environment] objectForKey: @"CbxServerPort"]).andReturn("41799");
+
+    expect(self.testServer.server.port).equal(41799);
+}
+
 @end