Fix for the subdomain issue #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I change the code according to your PR but got an issue when the TLD is like .or.jp etc.. |
|
Thanks for letting me know. What would you like me to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account has a domain and a subdomain underneath it, Cpanel API returns them as separate zones (e. g.
test.example.comandexample.com). However, it will only let you create an_acme-challenge.test.example.comrecord via adding_acme-challenge.testto theexample.comdomain - trying to add_acme-challengeto thetest.example.comerrors out.This PR changes the "find the zone for this domain" logic to look for the topmost (shortest) name.