Add TOML support with BaseTomlService #9438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
jNullj
force-pushed
the
feat/9410/toml-support
branch
2 times, most recently
from
d2c7d01
to
68c33f0
Compare
|
Seems to fail due to node16 in github workflow. |
chris48s
changed the title
|
Thanks. I've now merged the node 18 PR so you can update this branch to finish it off. I've removed I'll have a proper look over this at the weekend |
Add base toml service to enable fetch of toml files Add spec file for the new toml service for automated testing This was added to allow a new way to retrive python version from pyproject.toml as described in issue badges#9410
jNullj
force-pushed
the
feat/9410/toml-support
branch
from
68c33f0
to
6e26a52
Compare
chris48s
reviewed
Aug 11, 2023
Co-authored-by: chris48s <[email protected]>
solve code review badges#9438 (comment)
chris48s
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add base toml service to enable fetch of toml files
Add spec file for the new toml service for automated testing
This was added to allow a new way to retrive python version from pyproject.toml as described in issue #9410
Note: this adds a new dependency smol-toml which requires nodejs 18 or newer. i was testing this in nodejs 20 on my machine.
Note: when parsed, toml dates are a new extended date object (TomlDate) due to limitations in native js date, read more here.