Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume populator docs #833

Merged

Conversation

tesshuflower
Copy link
Contributor

Describe what this PR does

Is there anything that requires special attention?

Related issues:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

Do you mind taking a look when you get some time?

Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

docs/usage/volume-populator/index.rst Outdated Show resolved Hide resolved
Co-authored-by: John Strunk <[email protected]>
Signed-off-by: Tesshu Flower <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnStrunk
Copy link
Member

/lgtm

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #833 (0d5baef) into main (3325e59) will increase coverage by 0.1%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #833     +/-   ##
=======================================
+ Coverage   66.8%   66.9%   +0.1%     
=======================================
  Files         55      55             
  Lines       7058    7058             
=======================================
+ Hits        4716    4726     +10     
+ Misses      2061    2054      -7     
+ Partials     281     278      -3     

see 1 file with indirect coverage changes

@openshift-merge-robot openshift-merge-robot merged commit da269bb into backube:main Aug 25, 2023
23 checks passed
@tesshuflower tesshuflower deleted the volume_populator_docs branch August 29, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants