Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update restic to v0.17.1" #1412

Merged

Conversation

tesshuflower
Copy link
Contributor

@tesshuflower tesshuflower commented Oct 8, 2024

This reverts commit c3e5468.

Describe what this PR does

Rolls back to restic v0.17.0 for the moment.

  • Had issues on OpenShift with v0.17.1, due to this fix in restic: restore: clean up error handling when restoring metadata restic/restic#4958

  • Essentially now when running in privileged mode, restic will fail if restoring extended attributes fails. This will fail on OpenShift unless the namespace annotations for openshift.io/sa.scc.mcs match on the replicationdestination namespace. This is because OpenShift will not allow restoring these settings (unless we brute force allow privileged escalation and allow the pod to run in privileged mode, instead of just running as root).

  • Other extended attributes could also cause the restore to fail, such as security.* attributes. To restore those, we'd need to grant the privileged mover pod SYS_ADMIN capabilities.

  • For the moment we will roll back to v0.17.0 to maintain the current behavior, but may look into seeing if restic will allow flags to skip backing up/restoring specific extended attributes.

Is there anything that requires special attention?

Will want to cherry-pick this into release-0.11

Related issues:

https://issues.redhat.com/browse/ACM-14701

This reverts commit c3e5468.

Signed-off-by: Tesshu Flower <[email protected]>
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.5%. Comparing base (4a04600) to head (7dbc2a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1412     +/-   ##
=======================================
+ Coverage   67.4%   67.5%   +0.1%     
=======================================
  Files         57      57             
  Lines       5844    5844             
=======================================
+ Hits        3941    3947      +6     
+ Misses      1615    1612      -3     
+ Partials     288     285      -3     

see 1 file with indirect coverage changes

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk October 8, 2024 17:04
@tesshuflower
Copy link
Contributor Author

/cherry-pick release-0.11

@openshift-cherrypick-robot

@tesshuflower: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4bb451f into backube:main Oct 8, 2024
31 checks passed
@openshift-cherrypick-robot

@tesshuflower: new pull request created: #1413

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants