-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update restic to v0.17.1" #1412
Revert "Update restic to v0.17.1" #1412
Conversation
This reverts commit c3e5468. Signed-off-by: Tesshu Flower <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
=======================================
+ Coverage 67.4% 67.5% +0.1%
=======================================
Files 57 57
Lines 5844 5844
=======================================
+ Hits 3941 3947 +6
+ Misses 1615 1612 -3
+ Partials 288 285 -3 |
/cc @JohnStrunk |
/cherry-pick release-0.11 |
@tesshuflower: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tesshuflower: new pull request created: #1413 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This reverts commit c3e5468.
Describe what this PR does
Rolls back to restic v0.17.0 for the moment.
Had issues on OpenShift with v0.17.1, due to this fix in restic: restore: clean up error handling when restoring metadata restic/restic#4958
Essentially now when running in privileged mode, restic will fail if restoring extended attributes fails. This will fail on OpenShift unless the namespace annotations for
openshift.io/sa.scc.mcs
match on the replicationdestination namespace. This is because OpenShift will not allow restoring these settings (unless we brute force allow privileged escalation and allow the pod to run in privileged mode, instead of just running as root).Other extended attributes could also cause the restore to fail, such as security.* attributes. To restore those, we'd need to grant the privileged mover pod
SYS_ADMIN
capabilities.For the moment we will roll back to v0.17.0 to maintain the current behavior, but may look into seeing if restic will allow flags to skip backing up/restoring specific extended attributes.
Is there anything that requires special attention?
Will want to cherry-pick this into release-0.11
Related issues:
https://issues.redhat.com/browse/ACM-14701