-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subgraph_hash in dot parser. #129
base: master
Are you sure you want to change the base?
Conversation
Many thanks for this PR and #130. I'll have a look at it and I'll merge the two of them if possible. A quick question: have you checked that any |
Not yet. I forgot there are dot files inside these two folders. I can add a stanza in My PR currently is not so good, not only by (#130 Q2 Q3) but also my added structure for subgraph
I am also hoping I can remove |
It seems to take me nearly one year to answer this quick question 🎃. I am working on a WIP PR to test parsing those dot files with the current dot parser and my modified parser, then check the equality of the results. I added a dune alias I copied the current However, I don't figure out a good idea (ocamlgraph-way) to check the exactly equality of these two graphs in Now I just check they share the same number of vertices and edges. (The specific problem is I think some files just for testing during the PR discussion. When the issue is settled down, I can remove them. |
This PR adds a new entry function
parse_all
to get subgraph information when parsing a dot file.In the old code,
clust_nodes
is defined, and used, but not returned.It's replaced by a
graph_hash
which records the nodes, attr, and parent using the parsing.The previous parsing functions are only changed to drop not-use part of
create_graph_and_clusters
''s return values.I make an issue #130 for more discussion.