Migrated to MUI v5 #664
Migrated to MUI v5 #664
Conversation
| "@material-ui/icons": "^4.9.1", | ||
| "@mui/icons-material": "5.14.18", | ||
| "@mui/material": "5.14.18", | ||
| "@mui/styles": "5.14.18", |
There was a problem hiding this comment.
Is there's a better way to keep this in sync with Backstage itself I'm very much open to ideas.
There was a problem hiding this comment.
There was a problem hiding this comment.
@webark curious if you have any suggestions here based on you experience?
There was a problem hiding this comment.
It may be the case that we could revisit these being peer dependencies, like we do for react, react-dom etc. I.e. that all Backstage packages put them as peer deps and then it's up to the adopter to fulfil those in their packages/app to a concrete version. But I'm not sure it's the perfect solution, would have to bring it up with the team
Signed-off-by: Andre Wanlin <[email protected]>
Signed-off-by: Andre Wanlin <[email protected]>
awanlin
force-pushed
the
topic/mui5-migration
branch
from
2fc88c6 to
1d1a0ea
Compare
| "@material-ui/icons": "^4.9.1", | ||
| "@mui/icons-material": "5.14.18", | ||
| "@mui/material": "5.14.18", | ||
| "@mui/styles": "5.14.18", |
There was a problem hiding this comment.
It may be the case that we could revisit these being peer dependencies, like we do for react, react-dom etc. I.e. that all Backstage packages put them as peer deps and then it's up to the adopter to fulfil those in their packages/app to a concrete version. But I'm not sure it's the perfect solution, would have to bring it up with the team
| @@ -166,6 +166,7 @@ export const apertureTheme = createUnifiedTheme({ | |||
| }, | |||
| }, | |||
| }, | |||
| // @ts-ignore | |||
|
Closing for the time being based on some aspects still needing refinement. |
This migrates the Demo site
Appto use MUI v5 but there are still dependencies that use Material-UI v4 like@backstage/core-components.Note: this migration was pretty easy the place where I ran into the most issues was hitting and "
theme.spacingis not a function" TypeError. The fix was making sure that the@mui/materialand@mui/stylesversions matched what we were using upstream. This comment on this issue was key to helping me solve this: mui/material-ui#30611 (comment)