macOS CI, gardening, and various small fixups #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachand
commented
Jul 2, 2024
|
|
||
| ## Gotchas | ||
|
|
||
| - [`setup`](bin/setup) must be run from a directory underneath this repo. |
There was a problem hiding this comment.
The supported way to invoke bin/setup is via through the setup command shown earlier. The setup command ensures that the legacy setup script is invoked from within this repo.
bachand
commented
Jul 2, 2024
| @@ -12,9 +12,6 @@ alias cdr="cd $HOME/repos" | |||
| alias sn='code' | |||
| alias v='vim' | |||
|
|
|||
| alias cloudformation='aws cloudformation' | |||
There was a problem hiding this comment.
I do not recall using these aliases recently.
There was a problem hiding this comment.
I verified that these aliases aren't required by other code in this repository 👍
bachand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to smaller changes, Ruby tests now run in CI on macOS and I removed a gotcha from the README through a code change.
Testing
./bin/battlestation setuplocallyI ran this command twice on my M1 Max MacBook Pro. The command made updates during the first run and performed fewer steps in the second run, as expected.
There are a couple of issues during the beginning of the setup process that I will address in a future PR, as they are unrelated to this change.