Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opcc slashing event #139

Merged
merged 5 commits into from
Dec 12, 2024
Merged

feat: add opcc slashing event #139

merged 5 commits into from
Dec 12, 2024

Conversation

parketh
Copy link
Contributor

@parketh parketh commented Dec 11, 2024

Summary

This is a PR to update the BTC Slasher program to support and handle OP stack consumer chain slashing events.

It accompanies babylonlabs-io/babylon-contract#92.

Test plan

Before running integration tests, I needed to set DOCKER_HOST:

export DOCKER_HOST="unix:///Users/parkyeung/.docker/run/docker.sock"

To run tests:

# unit tests
make test

# integration tests
make test-e2e

CHANGELOG.md Outdated
Comment on lines 40 to 41
* [#135](https://github.com/babylonlabs-io/vigilante/pull/135) add opcc slashing event

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be #139

Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KonradStaniec Is it okay that for the main branch we have this piece of code for integration?

btcstaking-tracker/btcslasher/slasher.go Show resolved Hide resolved
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KonradStaniec Is it okay that for the main branch we have this piece of code for integration?

This seems like small piece of code so it should be fine 👍

Also e2e tests are passing so it should it seems that it is possible to subscribe to the messages that do not exists yet on Babylon (MsgEquivocationEvidence)

@parketh parketh merged commit b6e3b69 into main Dec 12, 2024
12 checks passed
@parketh parketh deleted the parketh/opcc-slashing branch December 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants