Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define v2 api endpoint #73

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Define v2 api endpoint #73

merged 10 commits into from
Oct 22, 2024

Conversation

jeremy-babylonlabs
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs commented Oct 14, 2024

due to the updated folder structure, there are alot of files changes. but the main difference would be grouping the shared api, queue and db functions in shared directory, while version specific files and functions are placed in v1 and v2 dir.

the latest v2 api endpoints and mock response can be found in internal/v2/api and shared/api dir.

closes #67

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the 67-define-v2-api-endpoint branch from 03d097e to 588dc24 Compare October 20, 2024 19:12
@jeremy-babylonlabs jeremy-babylonlabs marked this pull request as ready for review October 20, 2024 19:12
@jrwbabylonlab
Copy link
Collaborator

jrwbabylonlab commented Oct 21, 2024

@jeremy-babylonlabs the issue with the swagger failure is due to types are moved to other places.
So for example, the PublicResponse was under the same package before, but now moved to other places, hence you need to make sure the path is correct in swagger definition.

image

Copy link
Contributor

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, great work.

few notes/q's

  1. i am assuming the local setup is running ok after this v1/v2 regrouping?
  2. some ci jobs are failing

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the 67-define-v2-api-endpoint branch from d65b7b4 to 0dfde9a Compare October 22, 2024 06:50
@jeremy-babylonlabs jeremy-babylonlabs changed the title 67 define v2 api endpoint Define v2 api endpoint Oct 22, 2024
@jeremy-babylonlabs
Copy link
Contributor Author

#86

merging, will improve the handlers on another PR

@jeremy-babylonlabs jeremy-babylonlabs merged commit 5c37863 into main Oct 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define v2 API endpoints and mock data response
3 participants