-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define v2 api endpoint #73
Conversation
03d097e
to
588dc24
Compare
@jeremy-babylonlabs the issue with the swagger failure is due to types are moved to other places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, great work.
few notes/q's
- i am assuming the local setup is running ok after this v1/v2 regrouping?
- some ci jobs are failing
d65b7b4
to
0dfde9a
Compare
c0e8862
to
3f17f1e
Compare
merging, will improve the handlers on another PR |
due to the updated folder structure, there are alot of files changes. but the main difference would be grouping the shared api, queue and db functions in
shared
directory, while version specific files and functions are placed inv1
andv2
dir.the latest v2 api endpoints and mock response can be found in
internal/v2/api
andshared/api
dir.closes #67