Return combined v1 and v2 FP list #156
Conversation
- Added `transition_required` field to finality provider. - Combined v1 and v2 FP list
jeremy-babylonlabs
force-pushed
the
feat/155-fp-not-transitioned-state
branch
from
40a267a to
c5a2136
Compare
| return providersPublic, nil | ||
| } | ||
|
|
||
| // For V1: getFinalityProvidersFromGlobalParams returns the finality providers from the global params. |
There was a problem hiding this comment.
can you help me understand this -
why do we need global params here, don't we just need to fetch v1 and v2 fp's and then mark transitioned to those not in v2?
| } | ||
|
|
||
| for _, fp := range resultMap.Data { | ||
| var paramsPublic *FinalityProviderStatsPublic |
There was a problem hiding this comment.
i kind of don't understand some parts of this code,
we are getting fp's from global params and then also looking for the v1 fp stats and then injecting in response but if the v1 fp's have not transitioned why do we need the stats?
can you please help me understand purpose of this func?
There was a problem hiding this comment.
agreed here. we do not need the FP from phase-1 that do not have tvl
|
Closing as discussion in slack. FE will no longer show the pending transition hence we shall move the logic to the |
transition_requiredfield to finality provider.