Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support private repo authentication #43

Closed
wants to merge 20 commits into from

Conversation

maiquanghiep
Copy link

No description provided.

Copy link
Member

@filippos47 filippos47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-docker:
$(DOCKER) build --tag babylonlabs-io/finality-provider -f Dockerfile \
$(shell git rev-parse --show-toplevel)

For the build-docker job to work, we need to pass the token as a secret (ref)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@maiquanghiep maiquanghiep force-pushed the hiep/support-private-repo branch from b1da5c6 to 6615e77 Compare September 4, 2024 03:58
@gitferry
Copy link
Member

gitferry commented Dec 4, 2024

@maiquanghiep what is the status of this PR?

@maiquanghiep
Copy link
Author

maiquanghiep commented Dec 4, 2024

Looks like we no longer need the private repo authentication.
Will close if no objection @gitferry

@gitferry
Copy link
Member

gitferry commented Dec 4, 2024

Please close it then. Thanks @maiquanghiep

@maiquanghiep
Copy link
Author

Closing as we no longer need the private repo authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants