Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: finality gadget itest fix comments #35

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: test manager fixes
  • Loading branch information
parketh committed Aug 12, 2024
commit 30f2ee25463779aa4702acbbc7633da59d426d30
9 changes: 1 addition & 8 deletions itest/opstackl2/op_test_manager.go
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@ import (
defaultlog "log"
"os"
"path/filepath"
"strings"
"testing"
"time"

@@ -129,7 +128,7 @@ func StartOpL2ConsumerManager(t *testing.T, numOfConsumerFPs uint8) *OpL2Consume
L2RPCHost: opL2ConsumerConfig.OPStackL2RPCAddress,
BitcoinRPCHost: "rpc.ankr.com/btc",
FGContractAddress: opL2ConsumerConfig.OPFinalityGadgetAddress,
BBNChainID: "chain-test",
BBNChainID: e2eutils.ChainID,
BBNRPCAddress: opL2ConsumerConfig.RPCAddr,
DBFilePath: "data.db",
GRPCServerPort: babylonFinalityGadgetRpcPort,
@@ -527,11 +526,6 @@ func mockOpL2ConsumerCtrlConfig(nodeDataDir string) *fpcfg.OPStackL2Config {
}
}

func trimLeadingHttp(s string) string {
t := strings.TrimPrefix(s, "http://")
return strings.TrimPrefix(t, "https://")
}

func (ctm *OpL2ConsumerTestManager) WaitForServicesStart(t *testing.T) {
require.Eventually(t, func() bool {
params, err := ctm.BBNClient.QueryStakingParams()
@@ -841,7 +835,6 @@ func (ctm *OpL2ConsumerTestManager) WaitForBlockFinalized(
t.Logf(log.Prefix("failed to query latest finalized block %s"), err.Error())
return false
}
require.NoError(t, err)
finalizedBlockHeight = latestFinalizedBlock.Height
return finalizedBlockHeight >= checkedHeight
}, e2eutils.EventuallyWaitTimeOut, 5*ctm.getL2BlockTime())