Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename config ChainName to ChainType #24

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

bap2pecs
Copy link
Collaborator

@bap2pecs bap2pecs commented Aug 2, 2024

Summary

when I am doing the devnet integration, I realized that ChainName can cause confusion. e.g. OPStackL2 is not really a consumer chain name, it's actually a type

after the changes, the config will looks like this

[Application Options]
; Logging level for all subsystems
LogLevel = info

; the type of the consumer chain
ChainType = babylon

there are only 3 possible types:

const (
	BabylonConsumerChainType   = "babylon"
	OPStackL2ConsumerChainType = "OPStackL2"
	WasmConsumerChainType      = "wasm"
)

Test Plan

make build
./build/fpd init --home ./.fpd

and see the generated config file

run tests

make test
make test-e2e-op
make test-e2e-babylon

@bap2pecs bap2pecs marked this pull request as ready for review August 2, 2024 15:28
@bap2pecs bap2pecs changed the title chore: rename config ChainName to `ChainType chore: rename config ChainName to ChainType Aug 2, 2024
clientcontroller/factory.go Show resolved Hide resolved
finality-provider/config/config.go Outdated Show resolved Hide resolved
@bap2pecs bap2pecs merged commit f847046 into base/consumer-chain-support Aug 13, 2024
1 of 6 checks passed
@bap2pecs bap2pecs deleted the chore/rename-ChainName branch August 13, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants