Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove sync fp status loop #208

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

gitferry
Copy link
Member

Closes #191. In particular, this PR:

  • removed the loop for syncing fp status but syncing in the main thread during fp app initiation.
    • the loop is no longer needed as we have decided no fp will be registered via chain upgrade
    • we still need syncing status during initiation in case the fp is slashed or jailed
  • in monitorStatusUpdate, the check for jailing and slashing is removed. This is because the removal of voting power due to slashing or jailing happens in the next block. Countering jailing and slashing in the loop will cause the fp to not vote when it still have voting power for the current block

@gitferry gitferry changed the title remove sync fp status loop chore: Remove sync fp status loop Dec 10, 2024
@gitferry gitferry marked this pull request as ready for review December 10, 2024 03:54
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work!

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@gitferry gitferry merged commit c0600dc into main Dec 10, 2024
12 checks passed
@gitferry gitferry deleted the gai/remove-SyncFinalityProviderStatus branch December 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SyncFinalityProviderStatus
3 participants