fix: EOTS signing for multiple finality providers #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
approved these changes
Dec 6, 2024
|
|
||
| func getSignRecordKey(pk, chainID []byte, height uint64) []byte { | ||
| // calculate the randomn hash of the key concatenated with chainID and height | ||
| digest := hmac.New(sha256.New, pk) |
There was a problem hiding this comment.
hmm I wonder whether just concatenating bytes wouldn't be be better as key.
If the key is fpPk || height || chainID then finding all records for fp is just finding all keys with prefix fpPk || ... I am not sure what this hashing gives us except decreasing key slightly.
(this is not blocking though, we can disscuss it in separate issue)
There was a problem hiding this comment.
I agree. Will do it in this PR as db schema change in the future is troublesome
gitferry
added a commit
that referenced
this pull request
Dec 6, 2024
To support EOTS signing for multiple finality providers, the signing record should be saved with key (public key || chainID || height)
gitferry
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support EOTS signing for multiple finality providers, the signing record should be saved with key (public key || chainID || height)