chore: Remove last processed height #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazar955
approved these changes
Nov 27, 2024
| lastProcessedHeight := fp.GetLastProcessedHeight() | ||
| startHeight = fppath.MaxUint64(startHeight, lastProcessedHeight+1) | ||
| // consider the height after the last voted height | ||
| startHeight = fppath.MaxUint64(startHeight, fp.GetLastVotedHeight()+1) |
There was a problem hiding this comment.
Suggested change
| startHeight = fppath.MaxUint64(startHeight, fp.GetLastVotedHeight()+1) | |
| startHeight = max[uint64](startHeight, fp.GetLastVotedHeight()+1) |
There was a problem hiding this comment.
Nit, let's remove this util function and use go's built-in one. I see that we always pass 2 arguments anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lastProcessedHeightwas introduced for fast catch up blocks for which the fp does not have voting power. However, this case rarely happens and is unharmful. More discussions can be found here.