backport: Replace fast sync with batch processing #155
Conversation
Closes #118. Notable changes: * remove fast sync completely * introduce batch process for catching up * introduce signature submission interval to config * introduce batch submission size to config
gitferry
force-pushed
the
gai/backport-remove-fast-sync
branch
from
76de75b to
67b3e51
Compare
gitferry
force-pushed
the
gai/backport-remove-fast-sync
branch
from
214d1ab to
2a21b69
Compare
|
@bap2pecs Do you have any ideas why op_e2e_test failed? |
i think it's due to some of our test cases depend on the fast sync logic. it probably need some non-trivial refactoring. maybe we can just disable the op_e2e_test in CI for now? |
clientcontroller/babylon/babylon.go
Outdated
| } | ||
|
|
||
| // UnjailFinalityProvider sends an unjail transaction to the consumer chain | ||
| func (bc *BabylonController) UnjailFinalityProvider(fpPk *btcec.PublicKey) (*types.TxResponse, error) { |
There was a problem hiding this comment.
why is this added in this PR?
Good. Removed it and added todos in ci |
| SyncFpStatusInterval time.Duration `long:"syncfpstatusinterval" description:"The duration of time that it should sync FP status with the client blockchain"` | ||
| LogLevel string `long:"loglevel" description:"Logging level for all subsystems" choice:"trace" choice:"debug" choice:"info" choice:"warn" choice:"error" choice:"fatal"` | ||
| // ChainType and ChainID (if any) of the chain config identify a consumer chain | ||
| ChainType string `long:"chaintype" description:"the type of the consumer chain" choice:"babylon"` |
There was a problem hiding this comment.
ah it's caused this line change
Whoops. There was an error while executing your fpd CLI 'failed to load configuration: /home/finality-provider/.fpd/fpd.conf:6: Invalid value `OPStackL2' for option `--chaintype'. Allowed values are: 'bash-5.1$ fpd commit-pubrand -h
| res, err = fp.SubmitFinalitySignature(targetBlocks[0]) | ||
| } else { | ||
| select { | ||
| case <-time.After(fp.cfg.SubmissionRetryInterval): |
There was a problem hiding this comment.
ok I just found another problem. this will wait SubmissionRetryInterval even at the first iteration. Default value is set to 300 seconds. that's why I found out batch sig submission is very slow
I will send out a fix soon
Notable changes: