chore(*): fix lint config #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Nov 13, 2024
Comment on lines
+45
to
46
| //nolint:nilerr | ||
| return nil // if no conifg is found just stop. |
There was a problem hiding this comment.
I feel that this error can be returned
Comment on lines
+29
to
30
| //nolint:nilerr | ||
| return nil // config does not exist, so does not update it |
There was a problem hiding this comment.
also feel the error can be returned
| @@ -8,7 +8,6 @@ import ( | |||
| "sync/atomic" | |||
|
|
|||
| "cosmossdk.io/math" | |||
There was a problem hiding this comment.
what about renaming it to sdkmath?
|
|
||
| for _, tc := range tcs { | ||
| tc := tc |
There was a problem hiding this comment.
This might be a false positive by the linter, but remember in previous versions of golang when running a go routine in a loop you couldn't just pass the loop variable into the go routine but you had to either to this, or pass it as an argument to the go routine
| @@ -16,7 +16,6 @@ import ( | |||
| sdkmath "cosmossdk.io/math" | |||
| "github.com/babylonlabs-io/babylon/testutil/datagen" | |||
| bbn "github.com/babylonlabs-io/babylon/types" | |||
| bbntypes "github.com/babylonlabs-io/babylon/types" | |||
There was a problem hiding this comment.
curious why bbntypes not good?
There was a problem hiding this comment.
duplicate imports:
bbn "github.com/babylonlabs-io/babylon/types"
bbntypes "github.com/babylonlabs-io/babylon/types"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linting configuration (currently 126 issues outstanding)