Skip to content

Commit

Permalink
chore: Change btc_pk text to eots_pk (#179)
Browse files Browse the repository at this point in the history
Closes #144
  • Loading branch information
gitferry authored Dec 2, 2024
1 parent dd94b92 commit 6565301
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Improvements

* [#175](https://github.com/babylonlabs-io/finality-provider/pull/175) adds: `eotsd version` command
* [#179](https://github.com/babylonlabs-io/finality-provider/pull/179) Change `btc_pk` text to `eots_pk` in CLI

### Bug Fixes

Expand Down
4 changes: 2 additions & 2 deletions docs/finality-provider-operation.md
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ your finality provider's details:

The response includes:
- `fp_addr`: Your Babylon account address of the finality provider
- `eots_pk_hex`: Your unique BTC public key identifier
- `eots_pk_hex`: Your unique EOTS public key identifier
- `description`: Your finality provider's metadata
- `commission`: Your set commission rate
- `status`: Current status of the finality provider.
Expand Down Expand Up @@ -665,4 +665,4 @@ removal from the active set.
> ⚠️ **Critical**: Slashing is irreversible and results in
> permanent removal from the network.
<!-- TODO: PROMETHEUS METRICS -->
<!-- TODO: PROMETHEUS METRICS -->
16 changes: 9 additions & 7 deletions finality-provider/cmd/fpd/daemon/daemon_commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,20 @@ package daemon

import (
"context"
"cosmossdk.io/math"
"encoding/hex"
"encoding/json"
"fmt"
"strconv"

"cosmossdk.io/math"
"github.com/babylonlabs-io/babylon/types"
"github.com/babylonlabs-io/finality-provider/finality-provider/proto"
"github.com/cosmos/cosmos-sdk/client"
sdkflags "github.com/cosmos/cosmos-sdk/client/flags"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
"strconv"

"github.com/babylonlabs-io/finality-provider/finality-provider/proto"

fpcmd "github.com/babylonlabs-io/finality-provider/finality-provider/cmd"
fpcfg "github.com/babylonlabs-io/finality-provider/finality-provider/config"
Expand Down Expand Up @@ -467,14 +469,14 @@ func runCommandAddFinalitySig(cmd *cobra.Command, args []string) error {
// CommandEditFinalityDescription edits description of finality provider
func CommandEditFinalityDescription() *cobra.Command {
var cmd = &cobra.Command{
Use: "edit-finality-provider [btc_pk]",
Use: "edit-finality-provider [eots_pk]",
Aliases: []string{"efp"},
Short: "Edit finality provider data without resetting unchanged fields",
Long: "Edit the details of a finality provider using the specified BTC public key. " +
"\nThe provided [btc_pk] must correspond to the Babylon address controlled by the key specified in fpd.conf. " +
Long: "Edit the details of a finality provider using the specified EOTS public key. " +
"\nThe provided [eots_pk] must correspond to the Babylon address controlled by the key specified in fpd.conf. " +
"\nIf one or more optional flags are passed (such as --moniker, --website, etc.), " +
"the corresponding values are updated, while unchanged fields retain their current values from the Babylon Node.",
Example: fmt.Sprintf(`fpd edit-finality-provider [btc_pk] --daemon-address %s --moniker "new-moniker"`, defaultFpdDaemonAddress),
Example: fmt.Sprintf(`fpd edit-finality-provider [eots_pk] --daemon-address %s --moniker "new-moniker"`, defaultFpdDaemonAddress),
Args: cobra.ExactArgs(1),
RunE: runCommandEditFinalityDescription,
}
Expand Down

0 comments on commit 6565301

Please sign in to comment.