fix: start fp after register (#246) [backport] (#248)

Starts the fp instance fp register
babylonlabs-io · Dec 23, 2024 · 16acd54 · 16acd54
1 parent 785dd57
commit 16acd54
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -41,6 +41,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 * [#244](https://github.com/babylonlabs-io/finality-provider/pull/244) fix: save key name mapping
 verifies if there is a eots client running
+* [#246](https://github.com/babylonlabs-io/finality-provider/pull/246) fix: start fp after register
 
 ## v0.14.1
 

diff --git a/finality-provider/service/app.go b/finality-provider/service/app.go
@@ -413,6 +413,14 @@ func (app *FinalityProviderApp) CreateFinalityProvider(
 			return nil, err
 		}
 
+		if err = app.startFinalityProviderInstance(storedFp.GetBIP340BTCPK(), ""); err != nil {
+			app.logger.Error(
+				"failed to start fp instance",
+				zap.String("eots_pk", pkHex),
+				zap.Error(err),
+			)
+		}
+
 		return &CreateFinalityProviderResult{
 			FpInfo: storedFp.ToFinalityProviderInfo(),
 			TxHash: successResponse.txHash,

diff --git a/itest/test_manager.go b/itest/test_manager.go
@@ -197,8 +197,6 @@ func (tm *TestManager) AddFinalityProvider(t *testing.T) *service.FinalityProvid
 	desc := newDescription(testMoniker)
 	_, err = fpApp.CreateFinalityProvider(cfg.BabylonConfig.Key, testChainID, passphrase, eotsPk, desc, &commission)
 	require.NoError(t, err)
-	err = fpApp.StartFinalityProvider(eotsPk, passphrase)
-	require.NoError(t, err)
 
 	cfg.RPCListener = fmt.Sprintf("127.0.0.1:%d", testutil.AllocateUniquePort(t))
 	cfg.Metrics.Port = testutil.AllocateUniquePort(t)